From lists at maximumtech.us Wed Oct 1 15:14:44 2008 From: lists at maximumtech.us (Jeremy Davis) Date: Wed, 1 Oct 2008 17:14:44 -0500 Subject: [freeside-devel] View Map Message-ID: <000001c92413$1c560db0$55022910$@us> Well here is my first of many patches. Let me know if I did something wrong. The patch adds a link to Google maps on the service and billing address. Thought I'd make the first one a simple one. Sincerely, Jeremy Davis, CEO Maximum Technologies, LLC Office 318.303.4725 www.maximumtech.us From lists at maximumtech.us Wed Oct 1 16:00:09 2008 From: lists at maximumtech.us (Jeremy Davis) Date: Wed, 1 Oct 2008 18:00:09 -0500 Subject: [freeside-devel] View Maps revised Message-ID: <000101c92419$74521ad0$5cf65070$@us> Needed to add a target so we didn't lose the current screen. This is patched against HEAD. Sincerely, Jeremy Davis, CEO Maximum Technologies, LLC Office 318.303.4725 www.maximumtech.us -------------- next part -------------- A non-text attachment was scrubbed... Name: freeside-head-viewmap.patch Type: application/octet-stream Size: 928 bytes Desc: not available Url : http://420.am/pipermail/freeside-devel/attachments/20081001/c346f966/attachment.obj From lists at maximumtech.us Wed Oct 1 17:19:01 2008 From: lists at maximumtech.us (Jeremy Davis) Date: Wed, 1 Oct 2008 19:19:01 -0500 Subject: [freeside-devel] employees Message-ID: <000501c92424$78fae160$6af0a420$@us> Adding a few fields in employees in anticipation of CRM-like functionality in freeside. Sincerely, Jeremy Davis, CEO Maximum Technologies, LLC Office 318.303.4725 www.maximumtech.us -------------- next part -------------- A non-text attachment was scrubbed... Name: freeside_HEAD_employee.patch Type: application/octet-stream Size: 2965 bytes Desc: not available Url : http://420.am/pipermail/freeside-devel/attachments/20081001/ad25bfef/attachment.obj From lists at maximumtech.us Thu Oct 2 12:46:56 2008 From: lists at maximumtech.us (Jeremy Davis) Date: Thu, 2 Oct 2008 14:46:56 -0500 Subject: [freeside-devel] svc_broadband Message-ID: <000a01c924c7$a0ed06f0$e2c714d0$@us> I'm sort stuck on what path to take on some of the new software I will be writing. I have the need to track more information than what is currently supported. It's a two part problem. 1.) More information in svc_broadband. Basically will need to have information for devices. Usernames, passwords, make, model, other various things like burstable speed settings for various exports to other devices. 2.) Inventory system to log and provision the above devices. Does it make more sense to write something else for the above functionality or just modify the existing modules to handle what is needed? What would be more apt to be integrated into future releases? I wasn't sure how modifying the inventory system would affect other systems, as I have no customers currently using the inventory feature. Sincerely, Jeremy Davis, CEO Maximum Technologies, LLC Office 318.303.4725 www.maximumtech.us From ivan at freeside.biz Sat Oct 4 17:22:03 2008 From: ivan at freeside.biz (Ivan Kohler) Date: Sat, 4 Oct 2008 17:22:03 -0700 Subject: [freeside-devel] View Maps revised In-Reply-To: <000101c92419$74521ad0$5cf65070$@us> References: <000101c92419$74521ad0$5cf65070$@us> Message-ID: <20081005002159.GE26028@420.am> On Wed, Oct 01, 2008 at 06:00:09PM -0500, Jeremy Davis wrote: > Needed to add a target so we didn't lose the current screen. This is > patched against HEAD. Index: httemplate/view/cust_main/contacts.html =================================================================== -<% $which{$which} %> address +% my $google_maps = $cust_main->get("${pre}address1"). ",". $cust_main->get("${pre}city"). ",". $cust_main->get("${pre}zip"). ",". $cust_main->get("${pre}state"); + +<% $which{$which} %> address (View Map) Should it be "city,state,zip", not "city,zip,state" ? And perhaps we should add ','.$cust_main->country_full if ->country ne 'US', right? And $google_maps should be URI escaped with uri_escape() before being used in the URL, don't you think? -- _ivan From lists at maximumtech.us Mon Oct 6 07:55:48 2008 From: lists at maximumtech.us (Jeremy Davis) Date: Mon, 6 Oct 2008 09:55:48 -0500 Subject: [freeside-devel] View Maps revised In-Reply-To: <20081005002159.GE26028@420.am> References: <000101c92419$74521ad0$5cf65070$@us> <20081005002159.GE26028@420.am> Message-ID: <000b01c927c3$9e28a6a0$da79f3e0$@us> > Should it be "city,state,zip", not "city,zip,state" ? And perhaps we > should add ','.$cust_main->country_full if ->country ne 'US', right? That would make logical sense, but it works as coded. I have the code running on multiple clients. I only have one non-us client and didn't think about "global" support. > And $google_maps should be URI escaped with uri_escape() before being > used in the URL, don't you think? Your probably right, I didn't think about this as freeside does a lot of data checks before entering data in the database. I will change the code for the 2 above situations and resubmit a patch. Sincerely, Jeremy Davis, CEO Maximum Technologies, LLC Office 318.303.4725 www.maximumtech.us From ivan at freeside.biz Mon Oct 6 18:52:52 2008 From: ivan at freeside.biz (Ivan Kohler) Date: Mon, 6 Oct 2008 18:52:52 -0700 Subject: [freeside-devel] View Maps revised In-Reply-To: <000b01c927c3$9e28a6a0$da79f3e0$@us> References: <000101c92419$74521ad0$5cf65070$@us> <20081005002159.GE26028@420.am> <000b01c927c3$9e28a6a0$da79f3e0$@us> Message-ID: <20081007015246.GA1695@420.am> On Mon, Oct 06, 2008 at 09:55:48AM -0500, Jeremy Davis wrote: > > And $google_maps should be URI escaped with uri_escape() before being > > used in the URL, don't you think? > > Your probably right, I didn't think about this as freeside does a lot of > data checks before entering data in the database. It does, but that doesn't mean the data is clean for a URL. ';', '&' and '?' are allowed, for example. If you're running the self-service and allow users to edit their own addresses, that would seem to provide a route for a possible end-customer to employee XSS attack... -- _ivan From ivan at freeside.biz Thu Oct 9 11:59:37 2008 From: ivan at freeside.biz (Ivan Kohler) Date: Thu, 9 Oct 2008 11:59:37 -0700 Subject: [freeside-devel] Programming and Account Manager/support jobs available at Freeside Internet Services, Inc. Message-ID: <20081009185932.GA10600@rootwood.420.am> Hi, Freeside Internet Services, Inc. has immediate openings for an experienced programmer as well as an account manager/support role (given the nature of our application, this is of course not your typical end-user support). Please see http://freeside.biz/mediawiki/index.php/Freeside:Support:HelpWanted and email me if you are interested. -- Ivan Kohler President & Head Geek, Freeside Internet Services, Inc. http://freeside.biz/ Debian GNU/Linux developer | CPAN author | cat person | ski addict From jeff at cmh.net Tue Oct 14 08:24:18 2008 From: jeff at cmh.net (Jeff Finucane) Date: Tue, 14 Oct 2008 11:24:18 -0400 (EDT) Subject: [freeside-devel] svc_broadband In-Reply-To: <000a01c924c7$a0ed06f0$e2c714d0$@us> Message-ID: <20081014152418.A8AD532E5E@cmheleu.cmh.net> On Thu, 2 Oct 2008 14:46:56 -0500 "Jeremy Davis" wrote: +---------- | To: "'Freeside development mailing list'" | Subject: [freeside-devel] svc_broadband | List-Help: | | I'm sort stuck on what path to take on some of the new software I will be | writing. I have the need to track more information than what is currently | supported. It's a two part problem. | | 1.) More information in svc_broadband. | Basically will need to have information for devices. Usernames, | passwords, make, model, other various things like burstable speed settings | for various exports to other devices. +---------- Khoff makes suggestions here: http://www.freeside.biz/mediawiki/index.php/Broadband_Services_Spec and points out that we already store usernames, passwords in svc_acct and that these are already tied to exports. The speed settings should probably go into svc_broadband. +---------- | 2.) Inventory system to log and provision the above devices. | | Does it make more sense to write something else for the above functionality | or just modify the existing modules to handle what is needed? What would be | more apt to be integrated into future releases? I wasn't sure how modifying | the inventory system would affect other systems, as I have no customers | currently using the inventory feature. +---------- Modifying the inventory table for make, model, (explicit?) serial number and moving towards a many to many relationship between inventory items and services (much like that between packages and services) would greatly broaden freeside's capabilities. -- jeff at cmh.net "There is no worse tyranny than to force a man to pay for what he does not want merely because you think it would be good for him." Professor Bernardo de le Paz [ R.A. Heinlein -- "The Moon is a Harsh Mistress" ]