[freeside-commits] branch master updated. ecf1c9cc0a20be6e489657e005ea771977b9f69c

Jonathan Prykop jonathan at 420.am
Wed Aug 3 17:18:38 PDT 2016


The branch, master has been updated
       via  ecf1c9cc0a20be6e489657e005ea771977b9f69c (commit)
      from  9c7c2549038d64b4cf84d794ef6f461495bab4e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ecf1c9cc0a20be6e489657e005ea771977b9f69c
Author: Jonathan Prykop <jonathan at freeside.biz>
Date:   Wed Aug 3 19:18:17 2016 -0500

    RT#71518: Bug in the address editor [fixed query cleanup]

diff --git a/httemplate/edit/process/cust_main.cgi b/httemplate/edit/process/cust_main.cgi
index 715e873..74f8f23 100755
--- a/httemplate/edit/process/cust_main.cgi
+++ b/httemplate/edit/process/cust_main.cgi
@@ -1,5 +1,15 @@
 % if ( $error ) {
 %   $cgi->param('error', $error);
+%   # workaround for create_uri_query's mangling of unicode characters,
+%   # false laziness with FS::Record::ut_coord
+%   use charnames ':full';
+%   for my $pre (qw(bill ship)) {
+%     foreach (qw( latitude longitude)) {
+%       my $coord = $cgi->param($pre.'_'.$_);
+%       $coord =~ s/\N{DEGREE SIGN}\s*$//;
+%       $cgi->param($pre.'_'.$_, $coord);
+%     }
+%   }
 %   my $query = $m->scomp('/elements/create_uri_query', 'secure'=>1);
 <% $cgi->redirect(popurl(2). "cust_main.cgi?$query" ) %>
 %
@@ -59,12 +69,6 @@ if ( $conf->exists('agent-ship_address', $cgi->param('agentnum')) ) {
 my %locations;
 for my $pre (qw(bill ship)) {
 
-  foreach (qw( latitude longitude)) {
-    my $coord = $cgi->param($pre.'_'.$_);
-    $coord =~ s/\N{DEGREE SIGN}\s*$//;
-    $cgi->param($pre.'_'.$_, $coord);
-  }
-
   my %hash;
   foreach ( FS::cust_main->location_fields ) {
     $hash{$_} = scalar($cgi->param($pre.'_'.$_));

-----------------------------------------------------------------------

Summary of changes:
 httemplate/edit/process/cust_main.cgi |   16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)




More information about the freeside-commits mailing list