[freeside-commits] branch master updated. 160885729789305b2138d3474c07c953c43234f7

Ivan ivan at 420.am
Wed Jun 12 00:27:57 PDT 2013


The branch, master has been updated
       via  160885729789305b2138d3474c07c953c43234f7 (commit)
      from  4c4f4f3e38bb48e491ff7141b2a2e337f69386ae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 160885729789305b2138d3474c07c953c43234f7
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Wed Jun 12 00:27:44 2013 -0700

    remove obsolete code

diff --git a/FS/FS/cust_main.pm b/FS/FS/cust_main.pm
index 18ad9e3..7e3e26a 100644
--- a/FS/FS/cust_main.pm
+++ b/FS/FS/cust_main.pm
@@ -973,47 +973,6 @@ sub insert_cust_pay {
 
 }
 
-=item reexport
-
-This method is deprecated.  See the I<depend_jobnum> option to the insert and
-order_pkgs methods for a better way to defer provisioning.
-
-Re-schedules all exports by calling the B<reexport> method of all associated
-packages (see L<FS::cust_pkg>).  If there is an error, returns the error;
-otherwise returns false.
-
-=cut
-
-sub reexport {
-  my $self = shift;
-
-  carp "WARNING: FS::cust_main::reexport is deprectated; ".
-       "use the depend_jobnum option to insert or order_pkgs to delay export";
-
-  local $SIG{HUP} = 'IGNORE';
-  local $SIG{INT} = 'IGNORE';
-  local $SIG{QUIT} = 'IGNORE';
-  local $SIG{TERM} = 'IGNORE';
-  local $SIG{TSTP} = 'IGNORE';
-  local $SIG{PIPE} = 'IGNORE';
-
-  my $oldAutoCommit = $FS::UID::AutoCommit;
-  local $FS::UID::AutoCommit = 0;
-  my $dbh = dbh;
-
-  foreach my $cust_pkg ( $self->ncancelled_pkgs ) {
-    my $error = $cust_pkg->reexport;
-    if ( $error ) {
-      $dbh->rollback if $oldAutoCommit;
-      return $error;
-    }
-  }
-
-  $dbh->commit or die $dbh->errstr if $oldAutoCommit;
-  '';
-
-}
-
 =item delete [ OPTION => VALUE ... ]
 
 This deletes the customer.  If there is an error, returns the error, otherwise
diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm
index 3d24ea5..0980577 100644
--- a/FS/FS/cust_pkg.pm
+++ b/FS/FS/cust_pkg.pm
@@ -3275,6 +3275,8 @@ order_pkgs methods in FS::cust_main for a better way to defer provisioning.
 
 =cut
 
+#looks like this is still used by the order_pkg and change_pkg methods in
+# ClientAPI/MyAccount, need to look into those before removing
 sub reexport {
   my $self = shift;
 

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main.pm |   41 -----------------------------------------
 FS/FS/cust_pkg.pm  |    2 ++
 2 files changed, 2 insertions(+), 41 deletions(-)




More information about the freeside-commits mailing list