[freeside-commits] freeside/FS/FS/ClientAPI Signup.pm,1.40,1.41

Ivan,,, ivan at wavetail.420.am
Fri Jul 13 16:52:24 PDT 2007


Update of /home/cvs/cvsroot/freeside/FS/FS/ClientAPI
In directory wavetail:/tmp/cvs-serv6052/FS/FS/ClientAPI

Modified Files:
	Signup.pm 
Log Message:
fix race condition where ->apply_payments_and_credits could double-apply in rare cases

Index: Signup.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/ClientAPI/Signup.pm,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -d -r1.40 -r1.41
--- Signup.pm	1 May 2007 20:00:55 -0000	1.40
+++ Signup.pm	13 Jul 2007 23:52:21 -0000	1.41
@@ -439,7 +439,10 @@
     #warn "[fs_signup_server] error billing new customer: $bill_error"
     #  if $bill_error;
 
-    $cust_main->apply_payments_and_credits;
+    $bill_error = $cust_main->apply_payments_and_credits;
+    #warn "[fs_signup_server] error applying payments and credits for".
+    #     " new customer: $bill_error"
+    #  if $bill_error;
 
     $bill_error = $cust_main->collect('realtime' => 1);
     #warn "[fs_signup_server] error collecting from new customer: $bill_error"



More information about the freeside-commits mailing list