From d65927fb45aa1c47d7f593db0142d14799b0fabf Mon Sep 17 00:00:00 2001
From: Jonathan Prykop <jonathan@freeside.biz>
Date: Thu, 14 Apr 2016 08:38:54 -0500
Subject: [PATCH] RT#41671 Fix double click prevention for all legacy buttons
 [renamed all from submit to submitButton]

---
 httemplate/browse/addr_block.cgi                | 2 +-
 httemplate/edit/cust_main_attach.cgi            | 2 +-
 httemplate/edit/cust_pkg_detail.html            | 2 +-
 httemplate/edit/cust_pkg_discount.html          | 2 +-
 httemplate/edit/cust_pkg_quantity.html          | 2 +-
 httemplate/edit/cust_pkg_salesnum.html          | 2 +-
 httemplate/edit/elements/ApplicationCommon.html | 6 +++---
 httemplate/edit/elements/part_svc_column.html   | 2 +-
 httemplate/edit/invoice_logo.html               | 4 ++--
 httemplate/edit/part_svc.cgi                    | 2 +-
 httemplate/edit/prospect_main-upload.html       | 2 +-
 httemplate/edit/quotation_pkg_detail.html       | 2 +-
 httemplate/elements/progress-init.html          | 4 ++--
 httemplate/misc/cancel_cust.html                | 2 +-
 httemplate/misc/cancel_pkg.html                 | 2 +-
 httemplate/misc/change_pkg_start.html           | 2 +-
 httemplate/misc/cust_bill-promised_date.html    | 2 +-
 httemplate/misc/cust_main_note-import.cgi       | 2 +-
 httemplate/misc/delay_susp_pkg.html             | 2 +-
 httemplate/misc/nms-add_iface.html              | 2 +-
 httemplate/misc/nms-add_router.html             | 2 +-
 httemplate/misc/progress-popup.html             | 8 ++++----
 httemplate/misc/recharge_svc.html               | 2 +-
 httemplate/misc/suspend_cust.html               | 2 +-
 httemplate/misc/timeworked.html                 | 2 +-
 httemplate/misc/unhold_pkg.html                 | 2 +-
 httemplate/misc/unsuspend_cust.html             | 2 +-
 httemplate/search/cust_pkg_svc.html             | 2 +-
 httemplate/view/svc_acct/change_svc.html        | 2 +-
 httemplate/view/svc_acct/change_svc_form.html   | 4 ++--
 30 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/httemplate/browse/addr_block.cgi b/httemplate/browse/addr_block.cgi
index ba40bfd43..536a4f741 100644
--- a/httemplate/browse/addr_block.cgi
+++ b/httemplate/browse/addr_block.cgi
@@ -111,7 +111,7 @@ $html_foot .= include( '/elements/select-agent.html',
                          'agent_null_right' => 'Broadband global configuration',
                      );
 $html_foot .= qq(
-  <INPUT TYPE="submit" NAME="submit" VALUE="Add">
+  <INPUT TYPE="submit" NAME="submitButton" VALUE="Add">
   </FORM>
 );
 
diff --git a/httemplate/edit/cust_main_attach.cgi b/httemplate/edit/cust_main_attach.cgi
index 0880c760a..ba40b307a 100755
--- a/httemplate/edit/cust_main_attach.cgi
+++ b/httemplate/edit/cust_main_attach.cgi
@@ -31,7 +31,7 @@
 </TABLE>
 <BR>
 % if(! $disabled) {
-<INPUT TYPE="submit" NAME="submit" 
+<INPUT TYPE="submit" NAME="submitButton" 
     VALUE="<% $attachnum ? emt("Apply changes") : emt("Upload File") %>">
 % }
 % if(defined $attach and $curuser->access_right('Delete attachment')) {
diff --git a/httemplate/edit/cust_pkg_detail.html b/httemplate/edit/cust_pkg_detail.html
index a1a6db6d3..37a801373 100644
--- a/httemplate/edit/cust_pkg_detail.html
+++ b/httemplate/edit/cust_pkg_detail.html
@@ -43,7 +43,7 @@
 </TABLE>
 
 <BR>
-<INPUT TYPE="submit" ID="submit" NAME="submit" VALUE="<% $title %>">
+<INPUT TYPE="submit" ID="submit" NAME="submitButton" VALUE="<% $title %>">
 
 </FORM>
 
diff --git a/httemplate/edit/cust_pkg_discount.html b/httemplate/edit/cust_pkg_discount.html
index e1e3daede..5aece573d 100755
--- a/httemplate/edit/cust_pkg_discount.html
+++ b/httemplate/edit/cust_pkg_discount.html
@@ -23,7 +23,7 @@
 </TABLE>
 
 <BR>
-<INPUT NAME="submit" TYPE="submit" VALUE="Discount package">
+<INPUT NAME="submitButton" TYPE="submit" VALUE="Discount package">
 
 </FORM>
 </BODY>
diff --git a/httemplate/edit/cust_pkg_quantity.html b/httemplate/edit/cust_pkg_quantity.html
index ec47ed6cb..eadd1b504 100755
--- a/httemplate/edit/cust_pkg_quantity.html
+++ b/httemplate/edit/cust_pkg_quantity.html
@@ -21,7 +21,7 @@
 </TABLE>
 
 <BR>
-<INPUT NAME="submit" TYPE="submit" VALUE="Change">
+<INPUT NAME="submitButton" TYPE="submit" VALUE="Change">
 
 </FORM>
 </BODY>
diff --git a/httemplate/edit/cust_pkg_salesnum.html b/httemplate/edit/cust_pkg_salesnum.html
index dba2a905e..da6c0e89b 100755
--- a/httemplate/edit/cust_pkg_salesnum.html
+++ b/httemplate/edit/cust_pkg_salesnum.html
@@ -21,7 +21,7 @@
 </TABLE>
 
 <BR>
-<INPUT NAME="submit" TYPE="submit" VALUE="Change">
+<INPUT NAME="submitButton" TYPE="submit" VALUE="Change">
 
 </FORM>
 </BODY>
diff --git a/httemplate/edit/elements/ApplicationCommon.html b/httemplate/edit/elements/ApplicationCommon.html
index a531eaad4..9c068c18e 100644
--- a/httemplate/edit/elements/ApplicationCommon.html
+++ b/httemplate/edit/elements/ApplicationCommon.html
@@ -103,7 +103,7 @@ function changed(what) {
   dst = what.options[what.selectedIndex].value;
 
   if ( dst == '' ) {
-    what.form.submit.disabled=true;
+    what.form.submitButton.disabled=true;
 %if ($use_sub_dst_thing && $src_pkey eq 'crednum') {
     what.form.tax_button.disabled=true;
     what.form.clear_button.disabled=true;
@@ -111,7 +111,7 @@ function changed(what) {
     return true;
   }
 
-  what.form.submit.disabled=false;
+  what.form.submitButton.disabled=false;
 %if ($use_sub_dst_thing && $src_pkey eq 'crednum') {
   what.form.tax_button.disabled=false;
   what.form.clear_button.disabled=false;
@@ -373,7 +373,7 @@ function src_amount_changed () {
 <BR>
 <CENTER><INPUT TYPE="submit"
                VALUE="Apply"
-               NAME="submit"
+               NAME="submitButton"
                ID="submit"
 % if ($use_sub_dst_thing && $can_change_credit) {
                onClick="src_amount_changed()"
diff --git a/httemplate/edit/elements/part_svc_column.html b/httemplate/edit/elements/part_svc_column.html
index bc679e577..1944e5f6f 100644
--- a/httemplate/edit/elements/part_svc_column.html
+++ b/httemplate/edit/elements/part_svc_column.html
@@ -273,7 +273,7 @@ my %communigate_fields = (
 &>
 % $svcpart = '' if $opt{clone};
 <BR>
-<INPUT NAME="submit"
+<INPUT NAME="submitButton"
        TYPE="button"
        VALUE="<% emt($svcpart ? 'Apply changes' : 'Add service') %>"
        onclick="fixup_submit('<%$svcdb%>')"
diff --git a/httemplate/edit/invoice_logo.html b/httemplate/edit/invoice_logo.html
index e1c61496f..f0064e274 100644
--- a/httemplate/edit/invoice_logo.html
+++ b/httemplate/edit/invoice_logo.html
@@ -54,7 +54,7 @@
 % if ( $mode eq 'upload' ) {
 
     Upload new logo (.<%uc($type)%> format): <INPUT TYPE="file" NAME="new_logo">
-    <BR><INPUT TYPE="submit" NAME="submit" VALUE="Upload">
+    <BR><INPUT TYPE="submit" NAME="submitButton" VALUE="Upload">
 
 % } elsif ( $mode eq 'preview' ) {
 
@@ -71,7 +71,7 @@
 
 % if ( $mode eq 'preview' ) {
   <BR>
-  <INPUT TYPE="submit" NAME="submit" VALUE="Change logo">
+  <INPUT TYPE="submit" NAME="submitButton" VALUE="Change logo">
 % }
 
 </FORM>
diff --git a/httemplate/edit/part_svc.cgi b/httemplate/edit/part_svc.cgi
index a07fc6005..fa5a81ab3 100755
--- a/httemplate/edit/part_svc.cgi
+++ b/httemplate/edit/part_svc.cgi
@@ -37,7 +37,7 @@
 </STYLE>
 <SCRIPT TYPE="text/javascript">
 function fixup_submit(layer) {
-  document.forms[layer].submit.disabled = true;
+  document.forms[layer].submitButton.disabled = true;
   fixup(document.forms[layer]);
   window[layer+'process'].call();
 }
diff --git a/httemplate/edit/prospect_main-upload.html b/httemplate/edit/prospect_main-upload.html
index 24b1caa4c..733e5c2f7 100644
--- a/httemplate/edit/prospect_main-upload.html
+++ b/httemplate/edit/prospect_main-upload.html
@@ -2,6 +2,6 @@
 
   <FORM ACTION="prospect_main-ocr.html" METHOD="POST" ENCTYPE="multipart/form-data">
   <INPUT TYPE="file" NAME="card">
-  <BR><INPUT TYPE="submit" NAME="submit" VALUE="Upload">
+  <BR><INPUT TYPE="submit" NAME="submitButton" VALUE="Upload">
 
 <% include('/elements/footer.html') %>
diff --git a/httemplate/edit/quotation_pkg_detail.html b/httemplate/edit/quotation_pkg_detail.html
index 036bffdde..10d5af052 100644
--- a/httemplate/edit/quotation_pkg_detail.html
+++ b/httemplate/edit/quotation_pkg_detail.html
@@ -39,7 +39,7 @@
 </TABLE>
 
 <BR>
-<INPUT TYPE="submit" ID="submit" NAME="submit" VALUE="<% $title %>">
+<INPUT TYPE="submit" ID="submit" NAME="submitButton" VALUE="<% $title %>">
 
 </FORM>
 
diff --git a/httemplate/elements/progress-init.html b/httemplate/elements/progress-init.html
index e38dde65f..ba2e6be0d 100644
--- a/httemplate/elements/progress-init.html
+++ b/httemplate/elements/progress-init.html
@@ -92,8 +92,8 @@ function <%$key%>process () {
 
   //alert('<%$key%>process for form <%$formname%>');
 
-  if ( document.<%$formname%>.submit.disabled == false ) {
-    document.<%$formname%>.submit.disabled=true;
+  if ( document.<%$formname%>.submitButton.disabled == false ) {
+    document.<%$formname%>.submitButton.disabled=true;
   }
 
   overlib( 'Submitting job to server...', WIDTH, 444, HEIGHT, 168, CAPTION, 'Please wait...', STICKY, AUTOSTATUSCAP, CLOSETEXT, '', CLOSECLICK, MIDX, 0, MIDY, 0 );
diff --git a/httemplate/misc/cancel_cust.html b/httemplate/misc/cancel_cust.html
index 85367026c..d3da6fee1 100644
--- a/httemplate/misc/cancel_cust.html
+++ b/httemplate/misc/cancel_cust.html
@@ -55,7 +55,7 @@ toggle(false);
 
 <BR>
 <P ALIGN="CENTER">
-<INPUT TYPE="submit" NAME="submit" ID="confirm_cancel_cust_button" VALUE="<% mt('Cancel customer') |h %>" DISABLED> 
+<INPUT TYPE="submit" NAME="submitButton" ID="confirm_cancel_cust_button" VALUE="<% mt('Cancel customer') |h %>" DISABLED> 
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 <INPUT TYPE="BUTTON" VALUE="<% mt("Don't cancel") |h %>" onClick="parent.cClick();"> 
 
diff --git a/httemplate/misc/cancel_pkg.html b/httemplate/misc/cancel_pkg.html
index c80b2b278..bee206a13 100755
--- a/httemplate/misc/cancel_pkg.html
+++ b/httemplate/misc/cancel_pkg.html
@@ -91,7 +91,7 @@
 </TABLE>
 
 <BR>
-<INPUT TYPE="submit" NAME="submit" ID="confirm_cancel_pkg_button" 
+<INPUT TYPE="submit" NAME="submitButton" ID="confirm_cancel_pkg_button" 
   VALUE="<% mt($submit) |h %>"
   <% $method !~ /^(resume|uncancel)$/ ? 'DISABLED' : '' %>>
 
diff --git a/httemplate/misc/change_pkg_start.html b/httemplate/misc/change_pkg_start.html
index 5a890c86e..25a3c24b9 100755
--- a/httemplate/misc/change_pkg_start.html
+++ b/httemplate/misc/change_pkg_start.html
@@ -47,7 +47,7 @@
 &>
 </LI>
 </UL>
-<INPUT TYPE="submit" NAME="submit" VALUE="<% emt('Set start date') %>">
+<INPUT TYPE="submit" NAME="submitButton" VALUE="<% emt('Set start date') %>">
 
 </FORM>
 </BODY>
diff --git a/httemplate/misc/cust_bill-promised_date.html b/httemplate/misc/cust_bill-promised_date.html
index 7b7b9601d..0e417a2bb 100644
--- a/httemplate/misc/cust_bill-promised_date.html
+++ b/httemplate/misc/cust_bill-promised_date.html
@@ -9,7 +9,7 @@
   emt('Promised date'),
 &>
 </TABLE>
-<INPUT TYPE="submit" NAME="submit" VALUE="<% emt('Set date') %>">
+<INPUT TYPE="submit" NAME="submitButton" VALUE="<% emt('Set date') %>">
 </FORM>
 <& /elements/footer.html &>
 <%init>
diff --git a/httemplate/misc/cust_main_note-import.cgi b/httemplate/misc/cust_main_note-import.cgi
index 2e7dc8b65..12d6c36a4 100644
--- a/httemplate/misc/cust_main_note-import.cgi
+++ b/httemplate/misc/cust_main_note-import.cgi
@@ -190,7 +190,7 @@
 %      $row++;
 %    }
      </TABLE>
-     <INPUT TYPE="submit" NAME="submit" ID="importsubmit" VALUE="Import notes">
+     <INPUT TYPE="submit" NAME="submitButton" ID="importsubmit" VALUE="Import notes">
      <INPUT TYPE="checkbox" NAME="preview" onchange="previewChanged(this);">
      Preview mode
 %  } else {
diff --git a/httemplate/misc/delay_susp_pkg.html b/httemplate/misc/delay_susp_pkg.html
index 02f8824b4..6167509b9 100755
--- a/httemplate/misc/delay_susp_pkg.html
+++ b/httemplate/misc/delay_susp_pkg.html
@@ -36,7 +36,7 @@
 </TABLE>
 
 <BR>
-<INPUT TYPE="submit" NAME="submit" VALUE="<% $submit %>">
+<INPUT TYPE="submit" NAME="submitButton" VALUE="<% $submit %>">
 
 </FORM>
 </BODY>
diff --git a/httemplate/misc/nms-add_iface.html b/httemplate/misc/nms-add_iface.html
index 11456f2e8..74e1d8342 100644
--- a/httemplate/misc/nms-add_iface.html
+++ b/httemplate/misc/nms-add_iface.html
@@ -10,7 +10,7 @@ Torrus Service Id
 	  )
 %>
 <BR>
-<INPUT TYPE="submit" NAME="submit" ID="submit_nms-add_iface" VALUE="Add Interface">
+<INPUT TYPE="submit" NAME="submitButton" ID="submit_nms-add_iface" VALUE="Add Interface">
 </FORM>
 
 <%init>
diff --git a/httemplate/misc/nms-add_router.html b/httemplate/misc/nms-add_router.html
index c32ceb84c..3a8a15074 100644
--- a/httemplate/misc/nms-add_router.html
+++ b/httemplate/misc/nms-add_router.html
@@ -14,7 +14,7 @@ SNMP Community String (optional)
 %>
 <BR>
 <BR>
-<INPUT TYPE="submit" NAME="submit" ID="submit_nms-add_router" VALUE="Add Router">
+<INPUT TYPE="submit" NAME="submitButton" ID="submit_nms-add_router" VALUE="Add Router">
 </FORM>
 </BODY></HTML>
 <%init>
diff --git a/httemplate/misc/progress-popup.html b/httemplate/misc/progress-popup.html
index 8e2d6760b..66fe9a8a2 100644
--- a/httemplate/misc/progress-popup.html
+++ b/httemplate/misc/progress-popup.html
@@ -58,8 +58,8 @@ function updateStatus( status_statustext ) {
     document.getElementById("progress_jobnum").innerHTML = '';
 
 %   unless ( $url ) {
-        if ( parent.document.<%$formname%>.submit.disabled == true ) {
-          parent.document.<%$formname%>.submit.disabled=false;
+        if ( parent.document.<%$formname%>.submitButton.disabled == true ) {
+          parent.document.<%$formname%>.submitButton.disabled=false;
         }
 %   }
 
@@ -93,8 +93,8 @@ function updateStatus( status_statustext ) {
     document.getElementById("progress_bar").innerHTML = '';
     document.getElementById("progress_percent").innerHTML = '<INPUT TYPE="button" VALUE="OK" onClick="<% $onClick %>">';
     document.getElementById("progress_jobnum").innerHTML = '';
-    if ( parent.document.<%$formname%>.submit.disabled == true ) {
-      parent.document.<%$formname%>.submit.disabled=false;
+    if ( parent.document.<%$formname%>.submitButton.disabled == true ) {
+      parent.document.<%$formname%>.submitButton.disabled=false;
     }
   } else {
     alert('XXX unknown status returned from server: ' + status);
diff --git a/httemplate/misc/recharge_svc.html b/httemplate/misc/recharge_svc.html
index a1732fca5..593c0fafc 100755
--- a/httemplate/misc/recharge_svc.html
+++ b/httemplate/misc/recharge_svc.html
@@ -37,7 +37,7 @@
 </TABLE>
 
 <BR>
-<INPUT TYPE="submit" NAME="submit" VALUE="Recharge">
+<INPUT TYPE="submit" NAME="submitButton" VALUE="Recharge">
 
 </FORM>
 
diff --git a/httemplate/misc/suspend_cust.html b/httemplate/misc/suspend_cust.html
index 83d974300..7d2c5f65f 100644
--- a/httemplate/misc/suspend_cust.html
+++ b/httemplate/misc/suspend_cust.html
@@ -47,7 +47,7 @@ toggle(false);
 
 <BR>
 <P ALIGN="CENTER">
-<INPUT TYPE="submit" NAME="submit" ID="confirm_suspend_cust_button" VALUE="<% mt('Suspend customer') |h %>" DISABLED> 
+<INPUT TYPE="submit" NAME="submitButton" ID="confirm_suspend_cust_button" VALUE="<% mt('Suspend customer') |h %>" DISABLED> 
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 <INPUT TYPE="BUTTON" VALUE="<% mt("Don't suspend") |h %>" onClick="parent.cClick();"> 
 
diff --git a/httemplate/misc/timeworked.html b/httemplate/misc/timeworked.html
index a0cf74371..b24e31378 100755
--- a/httemplate/misc/timeworked.html
+++ b/httemplate/misc/timeworked.html
@@ -86,7 +86,7 @@
 <INPUT TYPE="hidden" NAME="end"      VALUE="<% $cgi->param('end')      |h %>">
 <INPUT TYPE="hidden" NAME="category" VALUE="<% $cgi->param('category') |h %>">
 
-<INPUT TYPE="submit" NAME="submit" VALUE="<% $title %>">
+<INPUT TYPE="submit" NAME="submitButton" VALUE="<% $title %>">
 </FORM>
 
 <% include('/elements/footer.html') %>
diff --git a/httemplate/misc/unhold_pkg.html b/httemplate/misc/unhold_pkg.html
index 0c110b4f9..40b55c62d 100755
--- a/httemplate/misc/unhold_pkg.html
+++ b/httemplate/misc/unhold_pkg.html
@@ -47,7 +47,7 @@
 &>
 </LI>
 </UL>
-<INPUT TYPE="submit" NAME="submit" VALUE="<% emt('Start billing') %>">
+<INPUT TYPE="submit" NAME="submitButton" VALUE="<% emt('Start billing') %>">
 
 </FORM>
 </BODY>
diff --git a/httemplate/misc/unsuspend_cust.html b/httemplate/misc/unsuspend_cust.html
index 4555a58b3..6c2c7070d 100644
--- a/httemplate/misc/unsuspend_cust.html
+++ b/httemplate/misc/unsuspend_cust.html
@@ -52,7 +52,7 @@ toggle(false);
 
 <BR>
 <P ALIGN="CENTER">
-<INPUT TYPE="submit" NAME="submit" ID="confirm_unsuspend_cust_button" VALUE="<% mt('Unsuspend customer') |h %>"> 
+<INPUT TYPE="submit" NAME="submitButton" ID="confirm_unsuspend_cust_button" VALUE="<% mt('Unsuspend customer') |h %>"> 
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;
 <INPUT TYPE="BUTTON" VALUE="<% mt("Don't unsuspend") |h %>" onClick="parent.cClick();"> 
 
diff --git a/httemplate/search/cust_pkg_svc.html b/httemplate/search/cust_pkg_svc.html
index cdc70351a..8a3c870fe 100644
--- a/httemplate/search/cust_pkg_svc.html
+++ b/httemplate/search/cust_pkg_svc.html
@@ -109,7 +109,7 @@ my $areboxes = 0;
 
 my $html_foot = qq!
 <BR>
-<INPUT TYPE="submit" NAME="submit" VALUE="Unprovision selected">
+<INPUT TYPE="submit" NAME="submitButton" VALUE="Unprovision selected">
 <INPUT TYPE="hidden" NAME="pkgnum" VALUE=$pkgnum>
 <INPUT TYPE="hidden" NAME="svcpart" VALUE=$svcpart>
 </FORM>!;
diff --git a/httemplate/view/svc_acct/change_svc.html b/httemplate/view/svc_acct/change_svc.html
index ed4aadd5f..045621488 100644
--- a/httemplate/view/svc_acct/change_svc.html
+++ b/httemplate/view/svc_acct/change_svc.html
@@ -9,7 +9,7 @@
 % } 
 
   </SELECT>
-  <INPUT NAME="submit" TYPE="submit" VALUE="<% mt('Change') |h %>" disabled>
+  <INPUT NAME="submitButton" TYPE="submit" VALUE="<% mt('Change') |h %>" disabled>
 
 % } 
 
diff --git a/httemplate/view/svc_acct/change_svc_form.html b/httemplate/view/svc_acct/change_svc_form.html
index 4f10922ba..7e2ef026d 100644
--- a/httemplate/view/svc_acct/change_svc_form.html
+++ b/httemplate/view/svc_acct/change_svc_form.html
@@ -2,9 +2,9 @@
     <SCRIPT TYPE="text/javascript">
       function enable_change () {
         if ( document.OneTrueForm.svcpart.selectedIndex > 1 ) {
-          document.OneTrueForm.submit.disabled = false;
+          document.OneTrueForm.submitButton.disabled = false;
         } else {
-          document.OneTrueForm.submit.disabled = true;
+          document.OneTrueForm.submitButton.disabled = true;
         }
       }
     </SCRIPT>
-- 
2.11.0