From a51e2d1d9c27f9329b3ff0305a60dbf773a11b71 Mon Sep 17 00:00:00 2001 From: Jonathan Prykop Date: Thu, 29 Oct 2015 22:17:08 -0500 Subject: [PATCH] RT#38671: Do not include charges and credits from failed signup processing [added void reason] --- FS/FS/ClientAPI/MyAccount.pm | 4 ++-- FS/FS/ClientAPI/Signup.pm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/FS/FS/ClientAPI/MyAccount.pm b/FS/FS/ClientAPI/MyAccount.pm index 89c70f75c..f272cd490 100644 --- a/FS/FS/ClientAPI/MyAccount.pm +++ b/FS/FS/ClientAPI/MyAccount.pm @@ -2521,8 +2521,8 @@ sub _do_bop_realtime { #this used to apply a credit, but now we can void invoices... foreach my $cust_bill (@cust_bill) { - my $voiderror = $cust_bill->void(); - warn "Error voiding cust bill after decline: $voiderror"; + my $voiderror = $cust_bill->void('automatic payment failed'); + warn "Error voiding cust bill after decline: $voiderror" if $voiderror; } } diff --git a/FS/FS/ClientAPI/Signup.pm b/FS/FS/ClientAPI/Signup.pm index a4ea21b8f..e166d407e 100644 --- a/FS/FS/ClientAPI/Signup.pm +++ b/FS/FS/ClientAPI/Signup.pm @@ -824,8 +824,8 @@ sub new_customer { #this used to apply a credit, but now we can void invoices... foreach my $cust_bill (@cust_bill) { - my $voiderror = $cust_bill->void(); - warn "Error voiding cust bill after decline: $voiderror"; + my $voiderror = $cust_bill->void('automatic payment failed'); + warn "Error voiding cust bill after decline: $voiderror" if $voiderror; } #should check list for errors... -- 2.11.0