From 311711639b41a5b307243d99c1aefceadcc97548 Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Sun, 17 Nov 2013 21:52:47 -0800 Subject: [PATCH] svc_cable label, RT#26013 --- FS/FS/svc_broadband.pm | 25 +++++++------------------ FS/FS/svc_cable.pm | 20 +++++++++++++++++++- 2 files changed, 26 insertions(+), 19 deletions(-) diff --git a/FS/FS/svc_broadband.pm b/FS/FS/svc_broadband.pm index 5b6912717..df5a438d6 100755 --- a/FS/FS/svc_broadband.pm +++ b/FS/FS/svc_broadband.pm @@ -1,9 +1,14 @@ package FS::svc_broadband; +use base qw( + FS::svc_Radius_Mixin + FS::svc_Tower_Mixin + FS::svc_MAC_Mixin + FS::svc_Common + ); use strict; use vars qw(@ISA $conf); -use base qw(FS::svc_Radius_Mixin FS::svc_Tower_Mixin FS::svc_Common); { no warnings 'redefine'; use NetAddr::IP; } use FS::Record qw( qsearchs qsearch dbh ); use FS::svc_Common; @@ -307,7 +312,7 @@ sub search_sql { =item label -Returns the IP address. +Returns the IP address, MAC address and description. =cut @@ -631,22 +636,6 @@ sub allowed_routers { =back -=item mac_addr_formatted CASE DELIMITER - -Format the MAC address (for use by exports). If CASE starts with "l" -(for "lowercase"), it's returned in lowercase. DELIMITER is inserted -between octets. - -=cut - -sub mac_addr_formatted { - my $self = shift; - my ($case, $delim) = @_; - my $addr = $self->mac_addr; - $addr = lc($addr) if $case =~ /^l/i; - join( $delim || '', $addr =~ /../g ); -} - #class method sub _upgrade_data { my $class = shift; diff --git a/FS/FS/svc_cable.pm b/FS/FS/svc_cable.pm index 26f4c89b1..726e6c370 100644 --- a/FS/FS/svc_cable.pm +++ b/FS/FS/svc_cable.pm @@ -1,5 +1,7 @@ package FS::svc_cable; -use base qw( FS::svc_Common ); #qw( FS::device_Common FS::svc_Common ); +use base qw( FS::svc_MAC_Mixin + FS::svc_Common + ); #FS::device_Common use strict; use Tie::IxHash; @@ -115,6 +117,22 @@ sub table_info { }; } +=item label + +Returns the MAC address and serial number. + +=cut + +sub label { + my $self = shift; + my @label = (); + push @label, 'MAC:'. $self->mac_addr_pretty + if $self->mac_addr; + push @label, 'Serial#:'. $self->serialnum + if $self->serialnum; + return join(', ', @label); +} + =item insert Adds this record to the database. If there is an error, returns the error, -- 2.11.0