From: Mark Wells <mark@freeside.biz>
Date: Tue, 31 Mar 2015 20:38:15 +0000 (-0700)
Subject: remove unnecessary methods in 4.x, #26828
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=8c720e8a4aae1937cf837009c864aebc64faa5b4

remove unnecessary methods in 4.x, #26828
---

diff --git a/FS/FS/FeeOrigin_Mixin.pm b/FS/FS/FeeOrigin_Mixin.pm
index 4eaf9b8d0..8bd9acd2c 100644
--- a/FS/FS/FeeOrigin_Mixin.pm
+++ b/FS/FS/FeeOrigin_Mixin.pm
@@ -110,13 +110,7 @@ sub cust_bill { '' }
 
 sub cust_pkg { '' }
 
-# stubs; remove in 4.x
-
-sub part_fee {
-  my $self = shift;
-  FS::part_fee->by_key($self->feepart);
-}
-
+# still necessary in 4.x; can't FK the billpkgnum because of voids
 sub cust_bill_pkg {
   my $self = shift;
   $self->billpkgnum ? FS::cust_bill_pkg->by_key($self->billpkgnum) : '';
diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm
index 4def528b8..be5bdea8f 100644
--- a/FS/FS/cust_pkg.pm
+++ b/FS/FS/cust_pkg.pm
@@ -1750,7 +1750,7 @@ sub unsuspend {
 
   if ( $reason ) {
     if ( $reason->unsuspend_pkgpart ) {
-      #warn "Suspend reason '".$reason->reason."' uses deprecated unsuspend_pkgpart feature.\n"; # in 4.x
+      warn "Suspend reason '".$reason->reason."' uses deprecated unsuspend_pkgpart feature.\n";
       my $part_pkg = FS::part_pkg->by_key($reason->unsuspend_pkgpart)
         or $error = "Unsuspend package definition ".$reason->unsuspend_pkgpart.
                     " not found.";
diff --git a/FS/FS/cust_pkg_reason_fee.pm b/FS/FS/cust_pkg_reason_fee.pm
index e5cc82910..1155c15ea 100644
--- a/FS/FS/cust_pkg_reason_fee.pm
+++ b/FS/FS/cust_pkg_reason_fee.pm
@@ -142,12 +142,6 @@ sub cust_pkg {
   $self->cust_pkg_reason->cust_pkg;
 }
 
-#stub - remove in 4.x
-sub cust_pkg_reason {
-  my $self = shift;
-  FS::cust_pkg_reason->by_key($self->pkgreasonnum);
-}
-
 =head1 SEE ALSO
 
 L<FS::FeeOrigin_Mixin>, L<FS::cust_pkg_reason>, L<part_fee>