From: Ivan Kohler <ivan@freeside.biz>
Date: Mon, 26 Jan 2015 05:43:32 +0000 (-0800)
Subject: manual echeck payment type, RT#26995
X-Git-Url: http://git.freeside.biz/gitweb/?p=freeside.git;a=commitdiff_plain;h=446fb74f2f31d48dd303c9a52105d40f11079e10

manual echeck payment type, RT#26995
---

diff --git a/FS/FS/cust_main/Billing_ThirdParty.pm b/FS/FS/cust_main/Billing_ThirdParty.pm
index faced8f2b..a1d19fb9e 100644
--- a/FS/FS/cust_main/Billing_ThirdParty.pm
+++ b/FS/FS/cust_main/Billing_ThirdParty.pm
@@ -36,7 +36,11 @@ to that URL.
 =cut
 
 my @methods = qw(PAYPAL CC);
-my %method2payby = ( 'PAYPAL' => 'PPAL', 'CC' => 'MCRD' );
+my %method2payby = ( 'PAYPAL' => 'PPAL',
+                     'CC'     => 'MCRD', #?  but doesn't MCRD mean _offline_
+                                         #card, not third-party card?  but no
+                                         #one is doing non-paypal right now
+                   );
 
 sub create_payment {
   my $self = shift;
diff --git a/FS/FS/cust_payby.pm b/FS/FS/cust_payby.pm
index 42bf64a3e..ad3d80a20 100644
--- a/FS/FS/cust_payby.pm
+++ b/FS/FS/cust_payby.pm
@@ -353,7 +353,7 @@ sub check {
   if ( $self->paydate eq '' || $self->paydate eq '-' ) {
     return "Expiration date required"
       # shouldn't payinfo_check do this?
-      unless $self->payby =~ /^(BILL|PREPAY|CHEK|DCHK|LECB|CASH|WEST|MCRD|PPAL)$/;
+      unless $self->payby =~ /^(BILL|PREPAY|CHEK|DCHK|LECB|CASH|WEST|MCRD|MCHK|PPAL)$/;
     $self->paydate('');
   } else {
     my( $m, $y );