FS RT #884 code review recommendations per mwells

diff --git a/httemplate/elements/menu.html b/httemplate/elements/menu.html
index 580c8de..d349045 100644 (file)
--- a/httemplate/elements/menu.html
+++ b/httemplate/elements/menu.html
@@ -113,8 +113,8 @@ tie my %report_customers, 'Tie::IxHash';
 $report_customers{'List customers'} = [ \%report_customers_lists, 'List customers' ]
   if $curuser->access_right('List all customers');
 $report_customers{'Zip code distribution'}     = [ $fsurl. 'search/report_cust_main-zip.html', 'Zip codes by number of customers' ];
-$report_customers{'Customer signup report'}    = [ $fsurl. 'graph/report_cust_signup.html',    'New customer signups by date' ],
-$report_customers{'Sign-up Date report'}       = [ $fsurl. 'graph/report_signupdate.html',     'Sign-up Date report (by date of sign-up)' ];
+$report_customers{'Customer signup report'}    = [ $fsurl. 'graph/report_cust_signup.html',    'New customer signups by date' ];
+$report_customers{'Signup date report'}        = [ $fsurl. 'graph/report_signupdate.html',     'Signup date report (by date of signup)' ];
 $report_customers{'Advanced customer reports'} = [ $fsurl. 'search/report_cust_main.html',     'by status, signup date, agent, etc.' ]
   if $curuser->access_right('Advanced customer search');
 

diff --git a/httemplate/graph/signupdate.cgi b/httemplate/graph/signupdate.cgi
index 43deddc..23e4596 100644 (file)
--- a/httemplate/graph/signupdate.cgi
+++ b/httemplate/graph/signupdate.cgi
@@ -36,13 +36,11 @@ $where{'usernum'}   = $usernum if $usernum;
 my $sdate = DateTime->new(
     year       => $cgi->param('start_year'),
     month      => $cgi->param('start_month'),
-    time_zone  => 'America/Los_Angeles',
 )->epoch();
 
 my $edate = DateTime->new(
     year       => $cgi->param('end_year'),
-    month      => $cgi->param('end_month'),
-    time_zone  => 'America/Los_Angeles',
+    month      => ($cgi->param('end_month') % 12 + 1) # first day of the next month
 )->epoch();
 
 my $where .= " AND signupdate >= $sdate ".