RT#34237: installer scheduling [fix steal]

[freeside.git] / httemplate / misc / xmlhttp-ticket-update.html

diff --git a/httemplate/misc/xmlhttp-ticket-update.html b/httemplate/misc/xmlhttp-ticket-update.html
index 46ed5bb..8735eec 100644 (file)
--- a/httemplate/misc/xmlhttp-ticket-update.html
+++ b/httemplate/misc/xmlhttp-ticket-update.html
@@ -8,14 +8,18 @@ my $username = $cgi->param('username');
 
 my $ticket = FS::TicketSystem->get_ticket_object( \%session, ticket_id=>$id );
 
-#hmm, this should happen in a single transaction and either commit or rollback,
-# but in reality failures "Don't Happen" so its not like a ticket gets
-# half changed
+#hmm, this should happen in a single transaction and either commit or rollback
 
 my $return;
 if ( $ticket ) {
 
-  my($orv, $omsg) = $ticket->SetOwner( $username, 'Steal' );
+  my $curowner = $ticket->OwnerObj->Name;
+  my($orv, $omsg);
+  if (( $curowner eq $FS::CurrentUser::CurrentUser->username ) or ( $curowner eq 'nobody' )) {
+    ($orv, $omsg) = $ticket->SetOwner( $username );
+  } else {
+    ($orv, $omsg) = $ticket->SetOwner( $username, 'Steal' );
+  }
   $orv = 1 if ! $orv && $omsg =~ /already own/i;
 
   if ( $orv ) {
@@ -50,7 +54,7 @@ if ( $ticket ) {
                   'sched_label' =>
                      FS::sched_avail::pretty_time($sh*60+$sm). '-'.
                      FS::sched_avail::pretty_time($eh*60+$em). ': '.
-                     $cust_main[0]->_FreesideURILabel,
+                     encode_entities($cust_main[0]->_FreesideURILabel),
                 };
     } else {
       $return = { 'error' => $smsg };