improve error messages (particularly for checks)

diff --git a/Changes b/Changes
index d85f6d3..dad4d99 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1,5 +1,8 @@
 Revision history for Perl extension Business::OnlinePayment::LinkPoint.
 
+0.08   Thu May 1 21:26:05 2007 UTC
+        - Improve error message for declined checks.
+
 0.07   Thu Apr 6 18:27:32 2007 UTC
        - Add account type mapping
         - map bank_state onto bankstate

diff --git a/LinkPoint.pm b/LinkPoint.pm
index 9b87643..84ea74e 100644 (file)
--- a/LinkPoint.pm
+++ b/LinkPoint.pm
@@ -1,6 +1,6 @@
 package Business::OnlinePayment::LinkPoint;
 
-# $Id: LinkPoint.pm,v 1.27 2007-04-07 00:01:29 jeff Exp $
+# $Id: LinkPoint.pm,v 1.28 2007-05-01 21:37:17 jeff Exp $
 
 use strict;
 use vars qw($VERSION @ISA $DEBUG @EXPORT @EXPORT_OK);
@@ -13,7 +13,7 @@ require Exporter;
 @ISA = qw(Exporter AutoLoader Business::OnlinePayment);
 @EXPORT = qw();
 @EXPORT_OK = qw();
-$VERSION = '0.07';
+$VERSION = '0.08';
 $DEBUG = 0;
 
 use lpperl; #3;  #lpperl.pm from LinkPoint
@@ -222,7 +222,9 @@ sub submit {
     } else {
       $self->is_success(0);
       $self->result_code('');
-      $self->error_message($response{'r_error'});
+      $response{'r_error'} =~/\S/
+        ? $self->error_message($response{'r_error'})
+        : $self->error_message($response{'r_approved'}); # no r_error for checks
     }
 
 }