From 9a4f4f3eb604881f976546566efc671ffe65fdf2 Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Wed, 13 Mar 2013 14:49:57 -0700 Subject: [PATCH] optimize line item detail "Paid" column inefficiency sometimes causing load issues for big installs, RT#21933 --- httemplate/search/cust_bill_pkg.cgi | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/httemplate/search/cust_bill_pkg.cgi b/httemplate/search/cust_bill_pkg.cgi index c81331345..c421711a5 100644 --- a/httemplate/search/cust_bill_pkg.cgi +++ b/httemplate/search/cust_bill_pkg.cgi @@ -677,12 +677,11 @@ if ( $cgi->param('nottax') ) { #total payments -my $pay_sub = "SELECT SUM(cust_bill_pay_pkg.amount) AS pay_amount, - billpkgnum - FROM cust_bill_pay_pkg - GROUP BY billpkgnum"; -$join_pkg .= " LEFT JOIN ($pay_sub) AS item_pay USING (billpkgnum)"; -push @select, 'item_pay.pay_amount'; +my $pay_sub = "SELECT SUM(cust_bill_pay_pkg.amount) + FROM cust_bill_pay_pkg + WHERE cust_bill_pkg.billpkgnum = cust_bill_pay_pkg.billpkgnum + "; +push @select, "($pay_sub) AS pay_amount"; #total credits my $credit_sub = "SELECT SUM(cust_credit_bill_pkg.amount) AS credit_amount, -- 2.11.0