X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=rt%2Flib%2FRT%2FObjectCustomFieldValues.pm;h=a2ec317e8fbaaaef1124c6d3d1a251e5608019ac;hb=008524b8e963831999983769f7fec11f55a72f16;hp=dad4a69176b52928dfb38bf63f0c9b32d806384f;hpb=85e677b86fc37c54e6de2b06340351a28f5a5916;p=freeside.git diff --git a/rt/lib/RT/ObjectCustomFieldValues.pm b/rt/lib/RT/ObjectCustomFieldValues.pm index dad4a6917..a2ec317e8 100644 --- a/rt/lib/RT/ObjectCustomFieldValues.pm +++ b/rt/lib/RT/ObjectCustomFieldValues.pm @@ -2,7 +2,7 @@ # # COPYRIGHT: # -# This software is Copyright (c) 1996-2012 Best Practical Solutions, LLC +# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC # # # (Except where explicitly superseded by other copyright notices) @@ -115,10 +115,10 @@ sub LimitToObject { } -=head2 HasEntry VALUE +=head2 HasEntry CONTENT LARGE_CONTENT -If this collection has an entry with content that eq VALUE then -returns the entry, otherwise returns undef. +If this collection has an entry with content that eq CONTENT and large content +that eq LARGE_CONTENT then returns the entry, otherwise returns undef. =cut @@ -126,11 +126,37 @@ returns the entry, otherwise returns undef. sub HasEntry { my $self = shift; my $value = shift; + my $large_content = shift; return undef unless defined $value && length $value; + my %canon_value; #TODO: this could cache and optimize a fair bit. foreach my $item ( @{$self->ItemsArrayRef} ) { - return $item if lc $item->Content eq lc $value; + my $cf = $item->CustomFieldObj; + my $args = $canon_value{ $cf->Type }; + if ( !$args ) { + $args = { Content => $value, LargeContent => $large_content }; + my ($ok, $msg) = $cf->_CanonicalizeValue( $args ); + next unless $ok; + $canon_value{ $cf->Type } = $args; + } + + if ( $cf->Type eq 'Select' ) { + # select is case insensitive + return $item if lc $item->Content eq lc $args->{Content}; + } + else { + if ( $item->_Value('Content') eq $args->{Content} ) { + if ( defined $item->LargeContent ) { + return $item + if defined $args->{LargeContent} + && $item->LargeContent eq $args->{LargeContent}; + } + else { + return $item unless defined $args->{LargeContent}; + } + } + } } return undef; } @@ -139,7 +165,7 @@ sub _DoSearch { my $self = shift; # unless we really want to find disabled rows, - # make sure we\'re only finding enabled ones. + # make sure we're only finding enabled ones. unless ( $self->{'find_expired_rows'} ) { $self->LimitToEnabled(); } @@ -151,7 +177,7 @@ sub _DoCount { my $self = shift; # unless we really want to find disabled rows, - # make sure we\'re only finding enabled ones. + # make sure we're only finding enabled ones. unless ( $self->{'find_expired_rows'} ) { $self->LimitToEnabled(); }