X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=OnlinePayment.pm;h=c8f7438ad8add8b94d567f30f880bf18b76da926;hb=b5883afef1f9e6b50c76ec6de39980fb820248fb;hp=3f95cd112701eb4f38fd0415a5be5cd414a65758;hpb=7e7195b0842a1c547cc4260ad4c25d1018961d27;p=Business-OnlinePayment.git

diff --git a/OnlinePayment.pm b/OnlinePayment.pm
index 3f95cd1..c8f7438 100644
--- a/OnlinePayment.pm
+++ b/OnlinePayment.pm
@@ -83,13 +83,13 @@ sub _risk_detect {
 	if ( $risk_transaction->fraud_score <= $self->maximum_fraud_score()) {
 	    return 1;
 	} else {
-	    $self->is_success(0);
 	    $self->error_message('Excessive risk from risk management');
 	}
     } else {
 	$self->error_message('Error in risk detection stage: ' .  $risk_transaction->error_message);
-	$self->is_success(0);
     }
+    $self->is_success(0);
+    return 0;
 }
 
 sub _pre_submit {
@@ -119,6 +119,7 @@ sub _pre_submit {
 	    }
 	}
     }
+    return 1; # BUG?: success if fraud_detection module not found!
 }
 
 sub content {