X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2Fbin%2Ffreeside-cdrrated;h=a8fcf5157f734e81ba18c401b304f4c7bf499cc6;hb=baca421d2fa815a6338e9525e3e404928b59235e;hp=f8b64a33bf35e1935bda190568f23146e0253975;hpb=23d5a00f2f0e0cb51204161eef7fdb69b1091b03;p=freeside.git

diff --git a/FS/bin/freeside-cdrrated b/FS/bin/freeside-cdrrated
index f8b64a33b..a8fcf5157 100644
--- a/FS/bin/freeside-cdrrated
+++ b/FS/bin/freeside-cdrrated
@@ -82,6 +82,7 @@ while (1) {
       my $svc_phone = qsearchs('svc_phone', { 'phonenum' => $number } );
       unless ( $svc_phone ) {
         #XXX set freesideratestatus or something so we don't keep retrying?
+        warn "no phone number found for CDR ". $cdr->acctid. "\n";
         next;
       }
 
@@ -94,7 +95,8 @@ while (1) {
       my $cust_pkg = $svc_phone{$number}->cust_svc->cust_pkg;
       unless ( $cust_pkg ) {
         #XXX unlinked svc_phone?
-        # warn and also set freesideratestatus or somesuch?
+        # also set freesideratestatus or somesuch?
+        warn "no package found (unlinked phone number?) for CDR ". $cdr->acctid. "\n";
         next;
       }
 
@@ -124,6 +126,7 @@ while (1) {
         #XXX no package for this CDR
         # warn and also set freesideratestatus or somesuch?
         #  or at least warn
+        warn "no CDR rating package for CDR ". $cdr->acctid. "\n";
         next;
       } elsif ( scalar(@part_pkg) > 1 ) {
         warn "multiple package could rate CDR ". $cdr->acctid. "\n";
@@ -140,6 +143,7 @@ while (1) {
       #then we can't prerate this CDR
       #some sort of warning?
       # (sucks if you're depending on credit limit fraud warnings)
+      warn "package has min_included; can't prerate CDR ". $cdr->acctid. "\n";
       next;
     }
     
@@ -149,9 +153,8 @@ while (1) {
       'svcnum'   => $svc_phone{$number}->svcnum,
     );
     if ( $error ) {
-      #XXX ???
-      warn $error;
-      sleep 30;
+      warn "Can't prerate CDR ". $cdr->acctid. ' to '. $cdr->dst. ": $error";
+      #could be an included minutes CDR, so don't sleep 30;
     } else {
 
       #this could get expensive on a per-call basis
@@ -185,7 +188,7 @@ sub _shouldrun {
 }
 
 sub usage { 
-  die "Usage:\n\n  freeside-cdrrewrited user\n";
+  die "Usage:\n\n  freeside-cdrrated user\n";
 }
 
 =head1 NAME