X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fpart_pkg%2Fdiscount_Mixin.pm;h=e411c84e8038abc7a8f2e9b939b8107d2156a736;hb=e2d16c850d8857567023f10b8c57daf0570c6a8e;hp=5de7d8ea54d7f18db55ad818aff8428871e101b4;hpb=1d8cf0f25e468b871d18962bda022c94d2934f02;p=freeside.git diff --git a/FS/FS/part_pkg/discount_Mixin.pm b/FS/FS/part_pkg/discount_Mixin.pm index 5de7d8ea5..e411c84e8 100644 --- a/FS/FS/part_pkg/discount_Mixin.pm +++ b/FS/FS/part_pkg/discount_Mixin.pm @@ -4,6 +4,7 @@ use strict; use vars qw( %info ); use Time::Local qw( timelocal ); use List::Util qw( min ); +use FS::Record qw( qsearchs ); use FS::cust_pkg; use FS::cust_bill_pkg_discount; @@ -122,17 +123,13 @@ sub calc_discount { if ( $discount->percent > 0 ) { $amount = $discount->percent * $param->{'setup_charge'} / 100; - } elsif ( $discount->amount > 0 && ($discount->months || 0) == 1) { + } elsif ( $discount->amount > 0 ) { # apply the discount amount, up to a maximum of the setup charge $amount = min($discount->amount, $param->{'setup_charge'}); $discount_left = sprintf('%.2f', $discount->amount - $amount); # transfer remainder of discount, if any, to recur $param->{'discount_left_recur'}{$discount->discountnum} = $discount_left; - } else { - # I guess we don't allow multiple-month flat amount discounts to - # apply to setup? - next; - } + } } else { @@ -141,7 +138,7 @@ sub calc_discount { # XXX it would be more accurate for calc_recur to just _tell us_ what # it's going to charge - my $recur_charge = $br * ($cust_pkg->quantity || 1) * $chg_months / $self->freq; + my $recur_charge = $br * $chg_months / $self->freq; # round this, because the real recur charge is rounded $recur_charge = sprintf('%.2f', $recur_charge);