X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fpart_pkg%2Fdiscount_Mixin.pm;h=56c86d520252cb53f0bcafff34a75ede457aea08;hb=df8debf67bd9d24505854ebf2b93ebf095c3e8ea;hp=335ff6d0f7fda250811057de3188d637085190f5;hpb=5c4da92af240d4a5d7f39e2478e344693817d5b7;p=freeside.git diff --git a/FS/FS/part_pkg/discount_Mixin.pm b/FS/FS/part_pkg/discount_Mixin.pm index 335ff6d0f..56c86d520 100644 --- a/FS/FS/part_pkg/discount_Mixin.pm +++ b/FS/FS/part_pkg/discount_Mixin.pm @@ -7,8 +7,6 @@ use List::Util qw( min ); use FS::cust_pkg; use FS::cust_bill_pkg_discount; -%info = ( 'disabled' => 1 ); - =head1 NAME FS::part_pkg::discount_Mixin - Mixin class for part_pkg:: classes that @@ -84,7 +82,9 @@ sub calc_discount { $amount += $discount->amount if $cust_pkg->pkgpart == $param->{'real_pkgpart'}; $amount += sprintf('%.2f', $discount->percent * $br / 100 ); - my $chg_months = $param->{'months'} || $cust_pkg->part_pkg->freq; + my $chg_months = defined($param->{'months'}) ? + $param->{'months'} : + $cust_pkg->part_pkg->freq; my $months = $discount->months ? min( $chg_months, @@ -166,11 +166,22 @@ sub calc_discount { $months = sprintf('%.2f', $months) if $months =~ /\./; my $d = 'Includes '; - $d .= 'setup ' if defined $param->{'setup_charge'}; - $d .= 'discount of '. $discount->description_short; - $d .= " for $months month". ( $months!=1 ? 's' : '' ) unless defined $param->{'setup_charge'}; - $d .= ": $money_char$amount" if $months != 1 || $discount->percent; + my $format; + + if ( $months eq '1' ) { + $d .= "discount of $money_char$amount each"; + $format = 'Undiscounted amount: %s%.2f'; + } else { + $d .= 'setup ' if defined $param->{'setup_charge'}; + $d .= 'discount of '. $discount->description_short; + $d .= " for $months month". ( $months!=1 ? 's' : '' ) + unless defined $param->{'setup_charge'}; + $d .= ": $money_char$amount" if $months != 1 || $discount->percent; + $format = 'Undiscounted monthly amount: %s%.2f'; + } + push @$details, $d; + push @$details, sprintf $format, $money_char, $br; $tot_discount += $amount; }