X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fpart_event%2FAction%2Fpkg_discount.pm;h=dd85ada9bf9c336d6fb8673dd857b7b648eda888;hb=7b6aaca51606e017c8f2a2c0f2de393bb817adec;hp=04a3a0f402c751ac6a7e2df17f1a5c9df401a474;hpb=ec7e8155fce544f19f2b6734476ed6db8c200aa9;p=freeside.git diff --git a/FS/FS/part_event/Action/pkg_discount.pm b/FS/FS/part_event/Action/pkg_discount.pm index 04a3a0f40..dd85ada9b 100644 --- a/FS/FS/part_event/Action/pkg_discount.pm +++ b/FS/FS/part_event/Action/pkg_discount.pm @@ -3,10 +3,12 @@ package FS::part_event::Action::pkg_discount; use strict; use base qw( FS::part_event::Action ); -sub description { "Discount active customer packages"; } +sub description { "Discount unsuspended package(s) (monthly recurring only)"; } sub eventtable_hashref { - { 'cust_main' => 1 }; + { 'cust_main' => 1, + 'cust_pkg' => 1, + }; } sub event_stage { 'pre-bill'; } @@ -21,16 +23,27 @@ sub option_fields { 'extra_sql' => q(AND freq NOT LIKE '0%' AND freq NOT LIKE '%d' AND freq NOT LIKE '%h' AND freq NOT LIKE '%w'), 'multiple' => 1, }, + 'if_pkg_class' => { label => 'Only package class', + type => 'select-pkg_class', + multiple => 1, + }, 'discountnum' => { 'label' => 'Discount', 'type' => 'select-table', #we don't handle the select-discount create a discount case 'table' => 'discount', - 'name_col' => 'description', #well, method - 'order_by' => 'ORDER BY discountnum', #requied because name_col is a method + #(well, since 2013 it winds up calling select-discount + # anyway (but not tr-select-discount) + #'name_col' => 'description', #well, method + #'order_by' => 'ORDER BY discountnum', #requied because name_col is a method + 'disable_empty' => 1, 'hashref' => { 'disabled' => '', 'months' => { op=>'!=', value=>'0' }, }, - 'disable_empty' => 1, + 'disable_custom_discount' => 1, }, + 'once_percust' => { 'label' => 'Only discount one package per customer', + 'type' => 'checkbox', + 'value' => 'Y', + }, ); } @@ -41,11 +54,38 @@ sub do_action { my $cust_main = $self->cust_main($object); my %if_pkgpart = map { $_=>1 } split(/\s*,\s*/, $self->option('if_pkgpart') ); - my @cust_pkg = grep { $if_pkgpart{ $_->pkgpart } && $_->part_pkg->freq - #can remove after fixing discount bug with non-monthly pkgs - && ( $_->part_pkg->freq =~ /^\d+$/) } - $cust_main->active_pkgs; - return 'No qualifying packages' unless @cust_pkg; + my $if_pkg_class = $self->option('if_pkg_class') || {}; + + my $allpkgs = (keys %if_pkgpart) ? 0 : 1; + + my @cust_pkg = (); + if ( $object->table eq 'cust_pkg' ) { + + return 'Package is suspended' if $object->susp; + return 'Package not selected' + if ! $allpkgs && ! $if_pkgpart{ $object->pkgpart }; + return 'Package not of selected class' + if keys %$if_pkg_class + && ! $if_pkg_class->{ $object->part_pkg->classnum }; + return 'Package frequency not monthly or a multiple' + if $object->part_pkg->freq !~ /^\d+$/; + + @cust_pkg = ( $object ); + + } else { + + @cust_pkg = grep { + ( $allpkgs || $if_pkgpart{ $_->pkgpart } ) + && ( ! keys %$if_pkg_class || $if_pkg_class->{ $_->part_pkg->classnum } ) + && $_->part_pkg->freq + #remove after fixing discount bug with non-monthly pkgs + && ( $_->part_pkg->freq =~ /^\d+$/) + } + $cust_main->unsuspended_pkgs; + + return 'No qualifying packages' unless @cust_pkg; + + } my $gotit = 0; foreach my $cust_pkg (@cust_pkg) { @@ -64,12 +104,20 @@ sub do_action { $gotit = 1; #it's already got this discount and discount never expires--great, move on - next unless $cust_pkg_discount[0]->discount->months; + unless ( $cust_pkg_discount[0]->discount->months ) { + if ( $self->option('once_percust') ) { + last; + } else { + next; + } + }; #reset the discount my $error = $cust_pkg_discount[0]->decrement_months_used( $cust_pkg_discount[0]->months_used ); die "Error extending discount: $error\n" if $error; + last if $self->option('once_percust'); + } elsif ( @cust_pkg_discount ) { #can't currently discount an already discounted package, @@ -87,6 +135,8 @@ sub do_action { my $error = $cust_pkg_discount->insert; die "Error discounting package: $error\n" if $error; + last if $self->option('once_percust'); + } }