X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fcdr.pm;h=fce7a14caf50d0d33e8a73186dd1d1356c562ba2;hb=5db92cf346acf4205aa96f58843a0a1d065f3988;hp=d3e44fedbbb207fdd0a4513a7180c582cd287d23;hpb=7344af8dd13cef85f7e58bbb258a56ed1f724e72;p=freeside.git diff --git a/FS/FS/cdr.pm b/FS/FS/cdr.pm index d3e44fedb..fce7a14ca 100644 --- a/FS/FS/cdr.pm +++ b/FS/FS/cdr.pm @@ -338,7 +338,7 @@ sub check { #check the foreign keys even? #do we want to outright *reject* the CDR? my $error = - $self->ut_numbern('acctid') + $self->ut_numbern('acctid'); #add a config option to turn these back on if someone needs 'em # @@ -350,7 +350,7 @@ sub check { # # # Telstra =1, Optus = 2, RSL COM = 3 # || $self->ut_foreign_keyn('carrierid', 'cdr_carrier', 'carrierid' ) - ; + return $error if $error; $self->SUPER::check; @@ -368,7 +368,14 @@ to inspect other field. sub is_tollfree { my $self = shift; my $field = scalar(@_) ? shift : 'dst'; - ( $self->$field() =~ /^(\+?1)?8(8|([02-7])\3)/ ) ? 1 : 0; + my $country = $conf->config('tollfree-country') || ''; + if ( $country eq 'AU' ) { + ( $self->$field() =~ /^(\+?61)?1800/ ) ? 1 : 0; + } elsif ( $country eq 'NZ' ) { + ( $self->$field() =~ /^(\+?64)?(800|508)/ ) ? 1 : 0; + } else { #NANPA (US/Canaada) + ( $self->$field() =~ /^(\+?1)?8(8|([02-7])\3)/ ) ? 1 : 0; + } } =item set_charged_party @@ -820,9 +827,10 @@ sub rate_prefix { # We don't round _anything_ (except granularizing) # until the final $charge = sprintf("%.2f"...). - my $seconds_left = $part_pkg->option_cacheable('use_duration') - ? $self->duration - : $self->billsec; + my $rated_seconds = $part_pkg->option_cacheable('use_duration') + ? $self->duration + : $self->billsec; + my $seconds_left = $rated_seconds; #no, do this later so it respects (group) included minutes # # charge for the first (conn_sec) seconds @@ -830,7 +838,7 @@ sub rate_prefix { # $seconds_left -= $seconds; # $weektime += $seconds; # my $charge = $rate_detail->conn_charge; - my $seconds = 0; + #my $seconds = 0; my $charge = 0; my $connection_charged = 0; @@ -888,7 +896,7 @@ sub rate_prefix { $seconds_left = 0; } - $seconds += $charge_sec; + #$seconds += $charge_sec; if ( $rate_detail->min_included ) { # the old, kind of deprecated way to do this: @@ -896,8 +904,8 @@ sub rate_prefix { # The rate detail itself has included minutes. We MUST have a place # to track them. my $included_min = $opt{'detail_included_min_hashref'} - or die "unable to rate CDR: rate detail has included minutes, but ". - "no detail_included_min_hashref provided.\n"; + or return "unable to rate CDR: rate detail has included minutes, but ". + "no detail_included_min_hashref provided.\n"; # by default, set the included minutes for this region/time to # what's in the rate_detail @@ -911,7 +919,7 @@ sub rate_prefix { $charge_sec -= ($included_min->{$regionnum}{$ratetimenum} * 60); $included_min->{$regionnum}{$ratetimenum} = 0; } - } elsif ( ${ $opt{'plan_included_min'} } > 0 ) { + } elsif ( $opt{plan_included_min} && ${ $opt{plan_included_min} } > 0 ) { # The package definition has included minutes, but only for in-group # rate details. Decrement them if this is an in-group call. if ( $rate_detail->region_group ) { @@ -982,7 +990,7 @@ sub rate_prefix { $opt{'svcnum'}, 'rated_pretty_dst' => $pretty_dst, 'rated_regionname' => $rate_region->regionname, - 'rated_seconds' => $seconds, + 'rated_seconds' => $rated_seconds, #$seconds, 'rated_granularity' => $rate_detail->sec_granularity, #$granularity 'rated_ratedetailnum' => $rate_detail->ratedetailnum, 'rated_classnum' => $rate_detail->classnum, #rated_ratedetailnum? @@ -1049,6 +1057,31 @@ sub rate_single_price { } +=item rate_cost + +Rates an already-rated CDR according to the cost fields from the rate plan. + +Returns the amount. + +=cut + +sub rate_cost { + my $self = shift; + + return 0 unless $self->rated_ratedetailnum; + + my $rate_detail = + qsearchs('rate_detail', { 'ratedetailnum' => $self->rated_ratedetailnum } ); + + return $rate_detail->min_cost if $self->rated_granularity == 0; + + my $minutes = $self->rated_seconds / 60; + my $charge = $rate_detail->conn_cost + $minutes * $rate_detail->min_cost; + + sprintf('%.2f', $charge + .00001 ); + +} + =item cdr_termination [ TERMPART ] =cut @@ -1210,6 +1243,10 @@ my %export_names = ( 'name' => 'Summary, one line per destination prefix', 'invoice_header' => 'Caller,Rate,Calls,Minutes,Price', }, + 'sum_count_class' => { + 'name' => 'Summary, one line per usage class', + 'invoice_header' => 'Caller,Class,Calls,Price', + }, ); my %export_formats = (); @@ -1221,7 +1258,7 @@ sub export_formats { my $conf = new FS::Conf; my $date_format = $conf->config('date_format') || '%m/%d/%Y'; - # call duration in the largest units that accurately reflect the granularity + # call duration in the largest units that accurately reflect the granularity my $duration_sub = sub { my($cdr, %opt) = @_; my $sec = $opt{seconds} || $cdr->billsec; @@ -1490,8 +1527,8 @@ as keys (for use with batch_import) and "pretty" format names as values. my %cdr_info; foreach my $INC ( @INC ) { - warn "globbing $INC/FS/cdr/*.pm\n" if $DEBUG; - foreach my $file ( glob("$INC/FS/cdr/*.pm") ) { + warn "globbing $INC/FS/cdr/[a-z]*.pm\n" if $DEBUG; + foreach my $file ( glob("$INC/FS/cdr/[a-z]*.pm") ) { warn "attempting to load CDR format info from $file\n" if $DEBUG; $file =~ /\/(\w+)\.pm$/ or do { warn "unrecognized file in $INC/FS/cdr/: $file\n";